Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow using sub query dimensions in join conditions #2419

Merged
merged 2 commits into from
Mar 23, 2021

Conversation

paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Mar 23, 2021

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@paveltiunov paveltiunov requested a review from a team as a code owner March 23, 2021 07:19
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Mar 23, 2021
@paveltiunov paveltiunov removed the pr:community Contribution from Cube.js community members. label Mar 23, 2021
@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #2419 (363725c) into master (9212fb9) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2419      +/-   ##
==========================================
- Coverage   56.32%   56.30%   -0.02%     
==========================================
  Files         118      118              
  Lines        8702     8711       +9     
  Branches     1894     1898       +4     
==========================================
+ Hits         4901     4905       +4     
- Misses       3435     3440       +5     
  Partials      366      366              
Impacted Files Coverage Δ
...es/cubejs-schema-compiler/src/adapter/BaseQuery.js 52.23% <100.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9212fb9...363725c. Read the comment docs.

@paveltiunov paveltiunov merged commit 496a075 into master Mar 23, 2021
@paveltiunov paveltiunov deleted the sub-query-join-filter branch March 23, 2021 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant