pretty default logger #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Justin-ZS Hey Jin! Thanks for contributing this! Logging is definitely a place that requires some improvements. There're log levels that have been requested some time ago. Would you like to implement those? It would help not to overwhelm console output. Something like
By event data I mean What do you think? |
|
@paveltiunov Fine, I will try to implement it after work. |
paveltiunov
requested changes
Oct 28, 2019
There was a problem hiding this comment.
@Justin-ZS Overall looks good! Could you please take a look at comments and fix linter and we're good to merge!
paveltiunov
approved these changes
Oct 30, 2019
|
@Justin-ZS Hey Jin! Looks good! Thanks again for contributing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After: