Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cubestore): temporarily disable top-k #2559

Merged
merged 1 commit into from
Apr 14, 2021
Merged

chore(cubestore): temporarily disable top-k #2559

merged 1 commit into from
Apr 14, 2021

Conversation

paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Apr 14, 2021 •
edited

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@paveltiunov paveltiunov requested a review from a team as a code owner April 14, 2021 20:56
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Apr 14, 2021
@paveltiunov paveltiunov removed the pr:community Contribution from Cube.js community members. label Apr 14, 2021
@paveltiunov paveltiunov merged commit ca668ea into master Apr 14, 2021
@paveltiunov paveltiunov deleted the cs-disable-topk branch April 14, 2021 21:11
ilya-biryukov added a commit that referenced this pull request Apr 15, 2021
@ilya-biryukov
fix(cubestore): allow to disable top-k with env var
15e087d 
Also adds more verbose logs for a panic that we hit in practice.
This also reverts commits:
  - ca668ea: Revert "chore(cubestore): temporarily disable top-k (#2559)"
  - eebb2fa: Revert "chore(cubestore): revert streaming once again: ignore topk tests"
@ilya-biryukov ilya-biryukov mentioned this pull request Apr 15, 2021
Merged
ilya-biryukov added a commit that referenced this pull request Apr 15, 2021
@ilya-biryukov
fix(cubestore): allow to disable top-k with env var
9c2838a 
Also adds more verbose logs for a panic that we hit in practice.
This also reverts commits:
  - ca668ea: Revert "chore(cubestore): temporarily disable top-k (#2559)"
  - eebb2fa: Revert "chore(cubestore): revert streaming once again: ignore topk tests"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paveltiunov @ilya-biryukov