Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ungrouped tag is not adapted in Clickhouse schema compiler #2717

Closed
donge opened this issue May 12, 2021 · 1 comment
Closed

ungrouped tag is not adapted in Clickhouse schema compiler #2717

donge opened this issue May 12, 2021 · 1 comment
Assignees
Labels
bug Something isn't working driver:clickhouse Issues relating to the Clickhouse driver

Comments

@donge
Copy link
Contributor

donge commented May 12, 2021

Describe the bug
ungrouped tag is not adapted in Clickhouse schema compiler

{"dimensions":["AccessAirlineView.url","AccessAirlineView.sid"],"ungrouped":true}

To Reproduce

  1. connet with Clickhouse as database.
  2. query with ungrouped tag.
  3. monitor the log under dev mode.
Performing query: 2f320dd1-b624-410e-a559-7b81851e7b75-span-1
Executing SQL: 2f320dd1-b624-410e-a559-7b81851e7b75-span-1
--
  SELECT
      `access_airline_view`.url `access_airline_view__url`, `access_airline_view`.sid `access_airline_view__sid`
    FROM
      default.access_airline_view AS `access_airline_view`
  GROUP BY `access_airline_view__url`, `access_airline_view__sid` ORDER BY `access_airline_view__url` ASC LIMIT 10000
--
  1. the is still group clause

Expected behavior

I try fix this issue, and get the right clause.

--
  SELECT
      `access_airline_view`.url `access_airline_view__url`, `access_airline_view`.sid `access_airline_view__sid`
    FROM
      default.access_airline_view AS `access_airline_view`
  ORDER BY `access_airline_view__url` ASC LIMIT 10000
--

Screenshots
If applicable, add screenshots to help explain your problem.

Version:
0.23.15

Additional context
will fix it myself:)

@hassankhan hassankhan added bug Something isn't working driver:clickhouse Issues relating to the Clickhouse driver labels May 12, 2021
@hassankhan
Copy link
Contributor

Hi @donge 👋

Thanks for posting the issue 🖐️ I've assigned it to you, looking forward to seeing a PR 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working driver:clickhouse Issues relating to the Clickhouse driver
Projects
None yet
Development

No branches or pull requests

2 participants