Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2717 support ungrouped tag for Clickhouse schema compiler #2719

Merged
merged 1 commit into from
May 12, 2021

Conversation

donge
Copy link
Contributor

@donge donge commented May 12, 2021

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet - tested in original issue reporyed.
  • Docs have been added / updated if required - no, need doc is common

Issue Reference this PR resolves

#2717

Description of Changes Made (if issue reference is not provided)

Reference to ES/RedShift adapter to fix in Clickhouse adapter

@donge donge requested a review from a team as a code owner May 12, 2021 10:53
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label May 12, 2021
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #2719 (37c446c) into master (6284a52) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2719      +/-   ##
==========================================
- Coverage   56.78%   56.77%   -0.02%     
==========================================
  Files         115      115              
  Lines        8777     8779       +2     
  Branches     1865     1866       +1     
==========================================
  Hits         4984     4984              
- Misses       3459     3460       +1     
- Partials      334      335       +1     
Impacted Files Coverage Δ
...ejs-schema-compiler/src/adapter/ClickHouseQuery.js 5.95% <0.00%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e88a088...37c446c. Read the comment docs.

@ovr ovr merged commit 82efc98 into cube-js:master May 12, 2021
@ovr
Copy link
Member

ovr commented May 12, 2021

Thank you @donge for the PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants