Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@cubejs-client/playground): telemetry #2727

Merged
merged 3 commits into from May 13, 2021
Merged

fix(@cubejs-client/playground): telemetry #2727

merged 3 commits into from May 13, 2021

Conversation

vasilev-alex
Copy link
Member

No description provided.

@vasilev-alex vasilev-alex requested a review from ovr May 13, 2021 08:31
@vasilev-alex vasilev-alex requested a review from a team as a code owner May 13, 2021 08:31
@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #2727 (324bb9f) into master (4231775) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2727      +/-   ##
==========================================
- Coverage   56.78%   56.76%   -0.02%     
==========================================
  Files         115      115              
  Lines        8777     8780       +3     
  Branches     1865     1867       +2     
==========================================
  Hits         4984     4984              
- Misses       3459     3460       +1     
- Partials      334      336       +2     
Impacted Files Coverage Δ
packages/cubejs-backend-shared/src/env.ts 42.27% <0.00%> (-0.35%) ⬇️
packages/cubejs-server-core/src/core/DevServer.ts 8.45% <ø> (ø)
packages/cubejs-server-core/src/core/server.ts 52.64% <ø> (ø)
...ejs-schema-compiler/src/adapter/ClickHouseQuery.js 5.95% <0.00%> (-0.15%) ⬇️
...ckages/cubejs-server-core/src/core/agentCollect.js 18.18% <0.00%> (ø)
...ges/cubejs-server-core/src/core/optionsValidate.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4231775...324bb9f. Read the comment docs.

Copy link
Member

@ovr ovr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ovr ovr added bug Something isn't working client:playground Issues relating to the Developer Playground labels May 13, 2021
@ovr ovr merged commit 366435a into master May 13, 2021
@ovr ovr deleted the telemetry-fix branch May 13, 2021 10:19
@rpaik rpaik added the Roadmap: 2021 Q2 Cube.js team roadmap for Q1 of 2021. label May 17, 2021
@rpaik rpaik added this to In progress in Roadmap 2021 Q2 via automation May 17, 2021
@rpaik rpaik linked an issue May 17, 2021 that may be closed by this pull request
2 tasks
@rpaik rpaik moved this from In progress to Done in Roadmap 2021 Q2 May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client:playground Issues relating to the Developer Playground Roadmap: 2021 Q2 Cube.js team roadmap for Q1 of 2021.
Projects
No open projects
3 participants