Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@cubejs-client/playground): stop processing query once it has changed #2731

Merged
merged 2 commits into from May 13, 2021

Conversation

vasilev-alex
Copy link
Member

No description provided.

@vasilev-alex vasilev-alex requested a review from ovr May 13, 2021 15:31
@vasilev-alex vasilev-alex requested a review from a team as a code owner May 13, 2021 15:31
@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #2731 (166926a) into master (4231775) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2731      +/-   ##
==========================================
- Coverage   56.78%   56.75%   -0.04%     
==========================================
  Files         115      115              
  Lines        8777     8780       +3     
  Branches     1865     1867       +2     
==========================================
- Hits         4984     4983       -1     
- Misses       3459     3461       +2     
- Partials      334      336       +2     
Impacted Files Coverage Δ
packages/cubejs-backend-shared/src/env.ts 42.27% <0.00%> (-0.35%) ⬇️
packages/cubejs-server-core/src/core/server.ts 52.38% <0.00%> (-0.27%) ⬇️
...ejs-schema-compiler/src/adapter/ClickHouseQuery.js 5.95% <0.00%> (-0.15%) ⬇️
packages/cubejs-server-core/src/core/DevServer.ts 8.45% <0.00%> (ø)
...ckages/cubejs-server-core/src/core/agentCollect.js 18.18% <0.00%> (ø)
...ges/cubejs-server-core/src/core/optionsValidate.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4231775...166926a. Read the comment docs.

@vasilev-alex vasilev-alex merged commit 3aed740 into master May 13, 2021
@vasilev-alex vasilev-alex deleted the cancel-load-on-query-change branch May 13, 2021 16:31
@rpaik rpaik added Roadmap: 2021 Q2 Cube.js team roadmap for Q1 of 2021. client:playground Issues relating to the Developer Playground labels May 17, 2021
@rpaik rpaik added this to In progress in Roadmap 2021 Q2 via automation May 17, 2021
@rpaik rpaik linked an issue May 17, 2021 that may be closed by this pull request
2 tasks
@rpaik rpaik moved this from In progress to Done in Roadmap 2021 Q2 May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client:playground Issues relating to the Developer Playground Roadmap: 2021 Q2 Cube.js team roadmap for Q1 of 2021.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Epic: Continued Playground improvements in Q2'2021
2 participants