Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporting CubejsApi class #2773

Merged
merged 1 commit into from May 19, 2021
Merged

Exporting CubejsApi class #2773

merged 1 commit into from May 19, 2021

Conversation

Spittal
Copy link
Contributor

@Spittal Spittal commented May 18, 2021

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

I have a specific authorization use case that I would like to add to the CubejsApi class. Without access to the class I have to modify the instantiated object which doesn't feel as clean or scalable.

This change just adds the CubejsApi class to the named exports so that more experienced developers can extend the API.

@Spittal Spittal requested a review from a team as a code owner May 18, 2021 20:32
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label May 18, 2021
@Spittal Spittal changed the title feat(@cubejs-client-core): exporting CubejsApi class Exporting CubejsApi class May 18, 2021
@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #2773 (d44bf98) into master (4dc55b4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2773   +/-   ##
=======================================
  Coverage   56.83%   56.83%           
=======================================
  Files         115      115           
  Lines        8792     8792           
  Branches     1871     1871           
=======================================
  Hits         4997     4997           
  Misses       3457     3457           
  Partials      338      338           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00e42b8...d44bf98. Read the comment docs.

@vasilev-alex vasilev-alex merged commit 03cfaff into cube-js:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants