Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@cubejs-client/core): decompose type #2849

Merged
merged 1 commit into from
May 28, 2021
Merged

Conversation

vasilev-alex
Copy link
Member

Closes #2814

@vasilev-alex vasilev-alex requested a review from a team as a code owner May 28, 2021 10:25
Copy link
Member

@ovr ovr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ЛГТМ

@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #2849 (5d0de25) into master (306d3ff) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2849   +/-   ##
=======================================
  Coverage   56.94%   56.94%           
=======================================
  Files         115      115           
  Lines        8874     8874           
  Branches     1931     1931           
=======================================
  Hits         5053     5053           
  Misses       3478     3478           
  Partials      343      343           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b854659...5d0de25. Read the comment docs.

@vasilev-alex vasilev-alex merged commit 60f2596 into master May 28, 2021
@vasilev-alex vasilev-alex deleted the decompose-type-fix branch May 28, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

decompose() with compareDateRange in typescript
2 participants