Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cube validation from updating BasePreAggregation #285

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

ferrants
Copy link
Contributor

@ferrants ferrants commented Dec 5, 2019

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves
None

Description of Changes Made (if issue reference is not provided)
Noticed this issue where BasePreAggregation would get updated

@paveltiunov
Copy link
Member

@ferrants Hey Matt! Nice catch! I'm curious what was affected by this bug?

@paveltiunov paveltiunov merged commit f4bda4e into cube-js:master Dec 5, 2019
@ferrants
Copy link
Contributor Author

ferrants commented Dec 5, 2019

I had been looking into implementing this (#276) last week and stumbled upon it.
Not ready by any means, not even sure if it's going to be necessary, but, there might be some logic in there that could be used for using Rollup Aggregations for querying without time dimension granularity.
master...ferrants:partition-date-range)

@paveltiunov
Copy link
Member

@ferrants Gotcha. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants