fix(SqliteDriver.js): Fixed table schema parsing

[philippefutureboy]

1- .match on line 52 returned null => fixed by removing the EOL character
2- The describe table returns the name of the field between square brackets => fixed by removing the square brackets (see https://www.sqlitetutorial.net/sqlite-tutorial/sqlite-describe-table/)

Check List

• Tests has been run in packages where changes made if available
• Linter has been run for changed code
• Tests for the changes have been added if not covered yet
• Docs have been added / updated if required

Issue Reference this PR resolves

(self contained, did not create an issue beforehand)

[paveltiunov]

@philippefutureboy Hey Philippe! Thanks for contributing this! I believe square brackets are optional. Should we support both cases: with and without square brackets?

[philippefutureboy]

@paveltiunov Hey Pavel :)
I didn't know that - we did not add any special parameters to the config object, and the db is a test db found online – https://www.dropbox.com/s/a2wax843eniq12g/flights.db?dl=0
Sure thing, if it is optional I can refactor that as a regex and match both cases.

Let me know :)

[paveltiunov]

@philippefutureboy Yeah. Please do. [ and ] are just escape symbols and those are completely optional. Those also include " and ```: https://www.sqlite.org/lang_keywords.html.

[philippefutureboy]

@paveltiunov Done!

To test, simply use the test data below:

var tables = JSON.parse('[{"name":"airlines","sql":"\nCREATE TABLE airlines (\n[index] INTEGER,\n  [id] TEXT,\n  [name] TEXT,\n  [alias] TEXT,\n  [iata] TEXT,\n  [icao] TEXT,\n  [callsign] TEXT,\n  [country] TEXT,\n  [active] TEXT\n)\n"},{"name":"airlines2","sql":"\nCREATE TABLE airlines2 (\n`index` INTEGER,\n  `id` TEXT,\n  `name` TEXT,\n  `alias` TEXT,\n  `iata` TEXT,\n  `icao` TEXT,\n  `callsign` TEXT,\n  `country` TEXT,\n  `active` TEXT\n)\n"},{"name":"airlines3","sql":"\nCREATE TABLE airlines3 (\n\"index\" INTEGER,\n  \"id\" TEXT,\n  \"name\" TEXT,\n  \"alias\" TEXT,\n  \"iata\" TEXT,\n  \"icao\" TEXT,\n  \"callsign\" TEXT,\n  \"country\" TEXT,\n  \"active\" TEXT\n)\n"},{"name":"airlines4","sql":"\nCREATE TABLE airlines4 (\nindex INTEGER,\n  id TEXT,\n  name TEXT,\n  alias TEXT,\n  iata TEXT,\n  icao TEXT,\n  callsign TEXT,\n  country TEXT,\n  active TEXT\n)\n"}]'

And run against the code at lines 49-65 :)

[paveltiunov]

@philippefutureboy Looks great! Thanks for contributing this! Really appreciate it!

[philippefutureboy]

Always a pleasure to contribute :)