Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Health check methods #308

Merged
merged 6 commits into from
Dec 24, 2019

Conversation

willhausman
Copy link
Contributor

#302

These are methods that can be used for checking health. I did not explicitly add an endpoint because the format of returning health checks varies slightly. These are methods that can be called with a custom implementation or using another package, e.g. terminus or lightship.

@paveltiunov
Copy link
Member

@willhausman Looks good to me! Also agree on endpoint. Would be nice to have it in the docs though as it may not seem obvious on how to add this health check route.

@paveltiunov paveltiunov merged commit 49ca36b into cube-js:master Dec 24, 2019
@willhausman willhausman deleted the health-check-methods branch December 24, 2019 05:17
@hemanthsj
Copy link

Thank you @willhausman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants