Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Close Cube Store on process.exit #3082

Merged
merged 1 commit into from
Jul 19, 2021
Merged

fix: Close Cube Store on process.exit #3082

merged 1 commit into from
Jul 19, 2021

Conversation

ovr
Copy link
Member

@ovr ovr commented Jul 9, 2021

Hello!

There is an issue Node.js when it doesn't kill child process: nodejs/node#13538. In this PR I did a workaround for it. Probably it's a default behaviour:

Still sounds like the wrong expectation to me. When SIGTERM terminates the parent, children get reparented to the grandparent. That's not node-specific, it's traditional UNIX behavior.

Thanks

@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #3082 (2d8ce8e) into master (815da47) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3082   +/-   ##
=======================================
  Coverage   59.59%   59.59%           
=======================================
  Files         124      124           
  Lines        9497     9497           
  Branches     2109     2109           
=======================================
  Hits         5660     5660           
  Misses       3551     3551           
  Partials      286      286           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 815da47...2d8ce8e. Read the comment docs.

@ovr ovr marked this pull request as ready for review July 19, 2021 10:33
@ovr ovr requested a review from a team as a code owner July 19, 2021 10:33
@ovr ovr merged commit f22f71a into master Jul 19, 2021
@ovr ovr deleted the cubestore-exit-bug branch July 19, 2021 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant