Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add env var for SNS || Pub/Sub topic #3086

Merged
merged 2 commits into from
Jul 29, 2021
Merged

feat: add env var for SNS || Pub/Sub topic #3086

merged 2 commits into from
Jul 29, 2021

Conversation

msambol
Copy link
Contributor

@msambol msambol commented Jul 9, 2021

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

#1014

Description of Changes Made (if issue reference is not provided)

Add explicit environment variable for SNS or Pub/Sub topic name.

@msambol msambol requested review from a team as code owners July 9, 2021 17:58
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Jul 9, 2021
@msambol msambol changed the title feat: add env var for SNS|Pub/Sub topic feat: add env var for SNS | Pub/Sub topic Jul 9, 2021
@msambol msambol changed the title feat: add env var for SNS | Pub/Sub topic feat: add env var for SNS || Pub/Sub topic Jul 9, 2021
@rpaik rpaik added backend:serverless-aws Issues relating to Cube Serverless AWS enhancement New feature proposal labels Jul 9, 2021
@rpaik rpaik linked an issue Jul 9, 2021 that may be closed by this pull request
SNS topic name is not propagated to both serverelss functions #1014
Closed
hassankhan
hassankhan approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@hassankhan hassankhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs changes LGTM 👍 Great work @msambol

@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #3086 (6c163e5) into master (7c06822) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3086   +/-   ##
=======================================
  Coverage   59.92%   59.92%           
=======================================
  Files         117      117           
  Lines        9129     9129           
  Branches     2014     2014           
=======================================
  Hits         5471     5471           
  Misses       3376     3376           
  Partials      282      282

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c06822...6c163e5. Read the comment docs.

@paveltiunov
Copy link
Member

@msambol Hey Michael! Thanks for contributing it!

@paveltiunov paveltiunov merged commit bc9289c into cube-js:master Jul 29, 2021
@msambol msambol deleted the sns-topic branch August 5, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hassankhan hassankhan hassankhan approved these changes

Assignees
No one assigned
Labels
backend:serverless-aws Issues relating to Cube Serverless AWS enhancement New feature proposal pr:community Contribution from Cube.js community members.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SNS topic name is not propagated to both serverelss functions
4 participants
@msambol @paveltiunov @hassankhan @rpaik