Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api-gateway): Debug API, allow subscribe to pre-aggregations queue events only by playground JWT #3144

Merged
merged 2 commits into from
Jul 22, 2021

Conversation

RusovDmitriy
Copy link
Member

@RusovDmitriy RusovDmitriy commented Jul 21, 2021

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

Debug API, allow subscribe to pre-aggregations queue events only by playground JWT

@RusovDmitriy RusovDmitriy requested a review from a team as a code owner July 21, 2021 16:08
@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #3144 (5ff6e36) into master (009156a) will decrease coverage by 21.28%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #3144       +/-   ##
===========================================
- Coverage   80.69%   59.41%   -21.29%     
===========================================
  Files          40      124       +84     
  Lines        3316     9518     +6202     
  Branches        0     2119     +2119     
===========================================
+ Hits         2676     5655     +2979     
- Misses        640     3577     +2937     
- Partials        0      286      +286     
Impacted Files Coverage Δ
...s-schema-compiler/scaffolding/ScaffoldingSchema.js
...ckages/cubejs-schema-compiler/adapter/BaseQuery.js
...ejs-schema-compiler/compiler/DataSchemaCompiler.js
...es/cubejs-schema-compiler/compiler/CompileError.js
...s/cubejs-schema-compiler/compiler/CompilerCache.js
...s/cubejs-schema-compiler/compiler/CubeValidator.js
...es/cubejs-schema-compiler/extensions/Reflection.js
...ema-compiler/compiler/CubePropContextTranspiler.js
...es/cubejs-schema-compiler/adapter/BaseDimension.js
...kages/cubejs-schema-compiler/adapter/MssqlQuery.js
... and 154 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46262b9...5ff6e36. Read the comment docs.

@RusovDmitriy RusovDmitriy changed the title fix(api-gateway): Allow subscribe to pre-aggregations queue events only by playground JWT fix(api-gateway): Debug API, allow subscribe to pre-aggregations queue events only by playground JWT Jul 22, 2021
@RusovDmitriy RusovDmitriy merged commit 700080f into master Jul 22, 2021
@RusovDmitriy RusovDmitriy deleted the fix-pre-agg-queue-security branch July 22, 2021 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant