Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Optimize timestamp formatting and table names loading for large partition range serving #3166

Merged
merged 4 commits into from
Jul 29, 2021

Conversation

paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Jul 29, 2021

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@paveltiunov paveltiunov requested a review from a team as a code owner July 29, 2021 00:15
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Jul 29, 2021
@paveltiunov paveltiunov removed the pr:community Contribution from Cube.js community members. label Jul 29, 2021
@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #3166 (8b78e6d) into master (483057a) will decrease coverage by 0.10%.
The diff coverage is 24.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3166      +/-   ##
==========================================
- Coverage   59.22%   59.11%   -0.11%     
==========================================
  Files         124      124              
  Lines        9554     9580      +26     
  Branches     2124     2133       +9     
==========================================
+ Hits         5658     5663       +5     
- Misses       3606     3626      +20     
- Partials      290      291       +1     
Impacted Files Coverage Δ
packages/cubejs-backend-shared/src/time.ts 20.00% <9.09%> (-11.25%) ⬇️
...y-orchestrator/src/orchestrator/PreAggregations.ts 84.98% <71.42%> (-0.02%) ⬇️
...-query-orchestrator/src/orchestrator/QueryQueue.js 70.08% <0.00%> (-0.64%) ⬇️
packages/cubejs-api-gateway/src/query.js 73.83% <0.00%> (ø)
...es/cubejs-server-core/src/core/RefreshScheduler.ts 71.57% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 483057a...8b78e6d. Read the comment docs.

@paveltiunov paveltiunov merged commit e1f8dc5 into master Jul 29, 2021
@paveltiunov paveltiunov deleted the optimize-partition-range-serving branch July 29, 2021 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant