Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pre-aggregations should have default refreshKey of every 1 hour if it doesn't set for Cube #3259

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Aug 16, 2021

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@paveltiunov paveltiunov requested a review from a team as a code owner August 16, 2021 05:46
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Aug 16, 2021
@paveltiunov paveltiunov removed the pr:community Contribution from Cube.js community members. label Aug 16, 2021
@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #3259 (fb15550) into master (bd25e7d) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3259      +/-   ##
==========================================
- Coverage   59.01%   58.95%   -0.06%     
==========================================
  Files         124      124              
  Lines        9710     9707       -3     
  Branches     2095     2092       -3     
==========================================
- Hits         5730     5723       -7     
- Misses       3698     3702       +4     
  Partials      282      282              
Impacted Files Coverage Δ
...es/cubejs-schema-compiler/src/adapter/BaseQuery.js 62.86% <100.00%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 705818b...fb15550. Read the comment docs.

@paveltiunov paveltiunov merged commit bc472aa into master Aug 16, 2021
@paveltiunov paveltiunov deleted the pre-aggs-default-refresh-key branch August 16, 2021 16:20
@rpaik rpaik linked an issue Aug 27, 2021 that may be closed by this pull request
3 tasks
@rpaik rpaik added this to Done in Roadmap 2021 Q3 Aug 27, 2021
@rpaik rpaik added backend:pre-aggregations Issues related to pre-aggregations Roadmap: 2021 Q3 Cube.js team roadmap for Q3 of 2021. labels Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:pre-aggregations Issues related to pre-aggregations Roadmap: 2021 Q3 Cube.js team roadmap for Q3 of 2021.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Epic: Improve refresh worker for pre-aggregations
2 participants