Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server-core): Wrapped ContinueWaitError for expandPartitionsInPreAggregations, refresh scheduler #3325

Merged
merged 2 commits into from
Aug 26, 2021

Conversation

RusovDmitriy
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

Wrapped ContinueWaitError for expandPartitionsInPreAggregations, refresh scheduler

@RusovDmitriy RusovDmitriy requested a review from a team as a code owner August 26, 2021 04:11
@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #3325 (111ed72) into master (9c0d4fe) will decrease coverage by 0.09%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3325      +/-   ##
==========================================
- Coverage   59.01%   58.91%   -0.10%     
==========================================
  Files         124      124              
  Lines        9750     9754       +4     
  Branches     2121     2122       +1     
==========================================
- Hits         5754     5747       -7     
- Misses       3714     3721       +7     
- Partials      282      286       +4     
Impacted Files Coverage Δ
...ges/cubejs-server-core/src/core/OrchestratorApi.ts 61.53% <83.33%> (+0.72%) ⬆️
packages/cubejs-server-core/src/core/logger.js 29.03% <0.00%> (-12.91%) ⬇️
...es/cubejs-server-core/src/core/RefreshScheduler.ts 74.72% <0.00%> (-1.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58a8cb4...111ed72. Read the comment docs.

@RusovDmitriy RusovDmitriy merged commit f37f977 into master Aug 26, 2021
@RusovDmitriy RusovDmitriy deleted the fix-pre-agg-and-wait-error branch August 26, 2021 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant