fix(cubejs-client-ngx): correct all filters being replaced on FilterMember.replace #3597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all filters with replacement
github-actions
bot
added
the
pr:community
Codecov Report
@@ Coverage Diff @@
## master #3597 +/- ##
=======================================
Coverage 59.71% 59.71%
=======================================
Files 125 125
Lines 10006 10006
Branches 2263 2263
=======================================
Hits 5975 5975
Misses 3749 3749
Partials 282 282 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
No test setup for package. May do a new PR and add tests to this package if I get some time in next few weeks.
Description of Changes Made (if issue reference is not provided)
Updated the .replace method on FilterMember for the client-cubejs-ngx library. The previous logic would update every single filter with the replaceWithName if the filter in question had a 'member' attribute; regardless of whether or not the member matched the item to replace.