fix(client-core): dayjs locale conflict #3606
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Hii^^ I'm using cubeJS for analytics API^^
First of all, thank you for creating a really great platform. thanks to you, I'm so into cubeJs these days..
Description of Changes Made (if issue reference is not provided)
if I change the locale value of dayjs on the front-end, no value is displayed when granularity is week.
Currently, if you look at the ResultSet code, the weekStart must be set to 1 to work properly.
However, the value can be modified by the client as much as possible (https://day.js.org/docs/en/i18n/changing-locale)
so it seems necessary to guide or cope with it.
To reproduces the problem, you can overwrite the locale of dayjs with ko or another value and test it.
please refer to the test code..
thank you^^