Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TypeError: Cannot read property 'joins' of null in case of queryRewrite returns empty query #3627

Merged
merged 1 commit into from Nov 4, 2021

Conversation

paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Nov 4, 2021

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@paveltiunov paveltiunov requested a review from a team as a code owner November 4, 2021 00:28
@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #3627 (e202cf2) into master (8d7ea9b) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3627      +/-   ##
==========================================
- Coverage   59.67%   59.67%   -0.01%     
==========================================
  Files         125      125              
  Lines       10014    10021       +7     
  Branches     2266     2270       +4     
==========================================
+ Hits         5976     5980       +4     
+ Misses       3756     3755       -1     
- Partials      282      286       +4     
Impacted Files Coverage Δ
packages/cubejs-api-gateway/src/query.js 72.80% <57.14%> (-1.03%) ⬇️
packages/cubejs-api-gateway/src/gateway.ts 68.05% <100.00%> (ø)
packages/cubejs-server-core/src/core/server.ts 62.98% <100.00%> (ø)
packages/cubejs-server-core/src/core/DevServer.ts 8.46% <0.00%> (ø)
...kages/cubejs-api-gateway/src/SubscriptionServer.ts 6.77% <0.00%> (ø)
...y-orchestrator/src/orchestrator/PreAggregations.ts 83.88% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ceb2135...e202cf2. Read the comment docs.

@paveltiunov paveltiunov merged commit d880d0c into master Nov 4, 2021
@paveltiunov paveltiunov deleted the post-rewrite-validate branch November 4, 2021 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant