Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api-gateway): Remove irrelevant GraphQL float filters #3778

Merged

Conversation

lvauvillier
Copy link
Contributor

@lvauvillier lvauvillier commented Dec 7, 2021

Remove irrelevant contains and notcontains from float filters

@lvauvillier lvauvillier requested a review from a team as a code owner December 7, 2021 09:55
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Dec 7, 2021
@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #3778 (f8ac0fb) into master (285b371) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3778      +/-   ##
==========================================
- Coverage   57.78%   57.74%   -0.04%     
==========================================
  Files         126      126              
  Lines       10543    10541       -2     
  Branches     2489     2489              
==========================================
- Hits         6092     6087       -5     
- Misses       4168     4171       +3     
  Partials      283      283              
Impacted Files Coverage Δ
packages/cubejs-api-gateway/src/graphql.ts 4.61% <ø> (+0.03%) ⬆️
...es/cubejs-schema-compiler/src/adapter/BaseQuery.js 63.66% <0.00%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 285b371...f8ac0fb. Read the comment docs.

@lvauvillier lvauvillier changed the title fix(graphql-api): Remove irrelevant GraphQL float filters fix(api-gateway): Remove irrelevant GraphQL float filters Dec 7, 2021
@vasilev-alex vasilev-alex merged commit 3147fe4 into cube-js:master Dec 7, 2021
@lvauvillier lvauvillier deleted the graphql-api-float-filter-fix branch December 7, 2021 22:20
hassankhan added a commit that referenced this pull request Dec 8, 2021
…api-reference

* master: (51 commits)
  docs(config): improve 'Migrating from Express to Docker' section
  docs(schema): improve copy and examples for Segments section in Pre-Aggregations (#3630)
  docs(config): update and improve 'Migrating from Express to Docker' section (#3783)
  docs: minor improvements to 'Getting Started with Docker' (#3784)
  docs(config): remove mentions of external driver (other than Cube Store) (#3782)
  docs: update product logos (#3781)
  docs(recipes): fix menu order (#3705)
  docs(config): add environment variables for Cube Store minIO support (#3739)
  docs(cloud): update multiple database connection instructions (#3771)
  docs: `extendContext` global usage warning (#3773)
  docs(frontend): rename 'Cube.js Frontend' to 'Frontend Integrations' (#3770)
  feat(api-gateway): Enable GraphiQL header editor to pass security context in dev mode (#3779)
  fix(graphql-api): Remove irrelevant float filters (#3778)
  fix(api-gateway): GraphQL boolean filters (#3776)
  chore(cubestore): User friendly connection timeout message
  chore: edit recipes
  chore: edit recipes
  feat(cubesql): Support performance_schema.session_variables & global_variables
  chore: edit readme
  chore(cubestore): Ignore ksql_simple test dead code
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants