Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@cubejs-client/core): restore support for Angular by removing dependency on @cubejs-client/dx #3972

Merged

Conversation

hassankhan
Copy link
Contributor

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@hassankhan hassankhan added bug Something isn't working client:core Issues relating to the JavaScript client SDK labels Jan 22, 2022
@hassankhan hassankhan self-assigned this Jan 22, 2022
@hassankhan hassankhan requested a review from a team as a code owner January 22, 2022 09:06
@codecov
Copy link

codecov bot commented Jan 22, 2022

Codecov Report

Merging #3972 (e76ae8b) into master (6084407) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3972   +/-   ##
=======================================
  Coverage   58.02%   58.02%           
=======================================
  Files         127      127           
  Lines       10646    10646           
  Branches     2592     2592           
=======================================
  Hits         6177     6177           
  Misses       3993     3993           
  Partials      476      476           
Flag Coverage Δ
cube-backend 58.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6084407...e76ae8b. Read the comment docs.

@paveltiunov paveltiunov merged commit 13d30dc into master Jan 22, 2022
@paveltiunov paveltiunov deleted the _hassankhancubedev/typegen/remove-dx-dep-from-core branch January 22, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client:core Issues relating to the JavaScript client SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants