Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Load metrics from DBT project #4000

Merged
merged 7 commits into from
Feb 2, 2022
Merged

Conversation

paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Jan 30, 2022

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

#3611

@paveltiunov paveltiunov requested review from a team as code owners January 30, 2022 02:53
@codecov
Copy link

codecov bot commented Jan 30, 2022

Codecov Report

Merging #4000 (f57d702) into master (c46552b) will decrease coverage by 13.83%.
The diff coverage is 38.46%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #4000       +/-   ##
===========================================
- Coverage   71.83%   58.00%   -13.84%     
===========================================
  Files          48      127       +79     
  Lines        4272    10662     +6390     
  Branches        0     2594     +2594     
===========================================
+ Hits         3069     6185     +3116     
- Misses       1203     3998     +2795     
- Partials        0      479      +479     
Flag Coverage Δ
cube-backend 58.00% <38.46%> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...schema-compiler/src/compiler/DataSchemaCompiler.js 51.08% <25.00%> (ø)
...hema-compiler/src/extensions/extension.abstract.ts 66.66% <33.33%> (ø)
...ges/cubejs-schema-compiler/src/extensions/index.ts 100.00% <100.00%> (ø)
packages/cubejs-schema-compiler/src/index.ts 100.00% <100.00%> (ø)
rust/cubesql/cubesql/src/config/mod.rs
...src/models/v1_load_request_query_time_dimension.rs
...sql/cubeclient/src/models/v1_load_continue_wait.rs
...sql/cubeclient/src/models/v1_load_request_query.rs
...pile/engine/information_schema/key_column_usage.rs
...st/cubesql/cubeclient/src/models/v1_load_result.rs
... and 169 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 404482d...f57d702. Read the comment docs.

@paveltiunov paveltiunov merged commit 2975d84 into master Feb 2, 2022
@paveltiunov paveltiunov deleted the dbt-schema-extension branch February 2, 2022 02:46
@rpaik rpaik added this to In Progress in Roadmap 2022 Q1 via automation Mar 14, 2022
@rpaik rpaik added the Roadmap: 2022 Q1 Cube roadmap for Q1 of 2022 label Mar 14, 2022
@rpaik rpaik moved this from In Progress to Done in Roadmap 2022 Q1 Mar 14, 2022
@rpaik rpaik linked an issue Mar 14, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Roadmap: 2022 Q1 Cube roadmap for Q1 of 2022
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Epic: Enable dbt integration
2 participants