Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@cubejs-backend/api-gateway): fix a type issue where queries did not properly support logical AND/OR operators #4016

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

rdwoodring
Copy link
Contributor

…ot properly support logical and and logical or operators

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves
#4007

Description of Changes Made (if issue reference is not provided)
Update query types in cubejs-api-gateway to properly support logical and and logical or operators.

…ot properly support logical and and logical or operators
@rdwoodring rdwoodring requested a review from a team as a code owner February 2, 2022 01:32
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Feb 2, 2022
@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #4016 (d8b9693) into master (c46552b) will decrease coverage by 13.80%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #4016       +/-   ##
===========================================
- Coverage   71.83%   58.03%   -13.81%     
===========================================
  Files          48      127       +79     
  Lines        4272    10651     +6379     
  Branches        0     2592     +2592     
===========================================
+ Hits         3069     6181     +3112     
- Misses       1203     3993     +2790     
- Partials        0      477      +477     
Flag Coverage Δ
cube-backend 58.03% <ø> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...esql/cubeclient/src/models/v1_cube_meta_measure.rs
rust/cubesql/cubesql/src/config/mod.rs
rust/cubesql/cubesql/src/compile/parser.rs
...ql/cubeclient/src/models/v1_cube_meta_dimension.rs
rust/cubesql/cubesql/src/mysql/auth_service.rs
rust/cubesql/cubesql/src/compile/engine/context.rs
...st/cubesql/cubeclient/src/models/v1_load_result.rs
...src/models/v1_load_request_query_time_dimension.rs
...pile/engine/information_schema/key_column_usage.rs
rust/cubesql/cubesql/src/transport/ext.rs
... and 165 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 404482d...d8b9693. Read the comment docs.

@hassankhan hassankhan changed the title fix(@cubejs-bacend/api-gateway): fix a type issue where queries did n… fix(@cubejs-backend/api-gateway): fix a type issue where queries did not properly support logical AND/OR operators Feb 2, 2022
@paveltiunov
Copy link
Member

@rdwoodring Hey Ryan! Thanks for contributing it!

@paveltiunov paveltiunov merged commit bb2d230 into cube-js:master Feb 2, 2022
@rdwoodring rdwoodring deleted the query-filter-type branch February 2, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants