Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transparency under the searchbar in some cases #4301

Merged
merged 1 commit into from Apr 4, 2022

Conversation

MrFlashAccount
Copy link
Contributor

@MrFlashAccount MrFlashAccount commented Apr 1, 2022

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

this pr fixes the transparency of the background of the search menu item in some weird cases.

@MrFlashAccount MrFlashAccount requested a review from a team as a code owner April 1, 2022 12:22
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Apr 1, 2022
@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #4301 (9f9b42d) into master (0ea9699) will decrease coverage by 9.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4301      +/-   ##
==========================================
- Coverage   68.04%   59.02%   -9.02%     
==========================================
  Files         233      133     -100     
  Lines       21496    10879   -10617     
  Branches     2561     2561              
==========================================
- Hits        14626     6421    -8205     
+ Misses       6595     4183    -2412     
  Partials      275      275              
Flag Coverage Δ
cube-backend 59.02% <ø> (ø)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t/cubesql/cubeclient/src/models/v1_load_request.rs
rust/cubesql/cubesql/src/sql/session_manager.rs
...pile/engine/information_schema/postgres/pg_proc.rs
rust/cubesql/cubesql/src/config/injection.rs
...ile/engine/information_schema/postgres/pg_range.rs
rust/cubesql/cubesql/src/sql/postgres/service.rs
...mpile/engine/information_schema/postgres/tables.rs
...engine/information_schema/postgres/pg_namespace.rs
...le/engine/information_schema/postgres/pg_tables.rs
rust/cubesql/cubesql/src/compile/context.rs
... and 90 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ea9699...9f9b42d. Read the comment docs.

@tenphi tenphi merged commit 6cdb20c into cube-js:master Apr 4, 2022
@MrFlashAccount MrFlashAccount deleted the bugfix/CC-275 branch April 4, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants