Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(playground): rollup designer count distinct warning #4309

Merged
merged 2 commits into from Apr 4, 2022

Conversation

vasilev-alex
Copy link
Member

No description provided.

@vasilev-alex vasilev-alex requested a review from a team as a code owner April 3, 2022 11:09
@vasilev-alex vasilev-alex requested a review from ovr April 4, 2022 07:33
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #4309 (d55ee2a) into master (c0244d1) will decrease coverage by 9.01%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master    #4309      +/-   ##
==========================================
- Coverage   68.04%   59.02%   -9.02%     
==========================================
  Files         233      133     -100     
  Lines       21537    10885   -10652     
  Branches     2561     2565       +4     
==========================================
- Hits        14655     6425    -8230     
+ Misses       6607     4185    -2422     
  Partials      275      275              
Flag Coverage Δ
cube-backend 59.02% <77.77%> (+<0.01%) ⬆️
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ejs-schema-compiler/src/adapter/PreAggregations.js 58.98% <77.77%> (+0.11%) ⬆️
...es/cubejs-schema-compiler/src/adapter/BaseQuery.js 65.59% <0.00%> (ø)
...engine/information_schema/postgres/pg_attribute.rs
...le/engine/information_schema/postgres/pg_tables.rs
...st/cubesql/cubeclient/src/models/v1_load_result.rs
...engine/information_schema/postgres/pg_namespace.rs
rust/cubesql/cubeclient/src/apis/default_api.rs
rust/cubesql/cubesql/src/lib.rs
...pile/engine/information_schema/postgres/pg_proc.rs
...st/cubesql/cubesql/src/compile/rewrite/language.rs
... and 92 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f02c5a...d55ee2a. Read the comment docs.

@vasilev-alex vasilev-alex merged commit add2dd3 into master Apr 4, 2022
@vasilev-alex vasilev-alex deleted the count-distinct-alert branch April 4, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant