Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metabase to_char query #4600

Merged
merged 5 commits into from
May 30, 2022
Merged

metabase to_char query #4600

merged 5 commits into from
May 30, 2022

Conversation

gandronchik
Copy link
Contributor

No description provided.

@gandronchik gandronchik requested a review from a team as a code owner May 26, 2022 11:42
@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #4600 (d17d871) into master (3e3e010) will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##           master    #4600   +/-   ##
=======================================
  Coverage   71.72%   71.73%           
=======================================
  Files         247      247           
  Lines       25991    26074   +83     
  Branches     2775     2792   +17     
=======================================
+ Hits        18642    18703   +61     
- Misses       6842     6865   +23     
+ Partials      507      506    -1     
Flag Coverage Δ
cube-backend 59.20% <ø> (+0.01%) ⬆️
cubesql 81.11% <75.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/cubesql/cubesql/src/compile/engine/udf.rs 87.54% <68.42%> (-0.94%) ⬇️
rust/cubesql/cubesql/src/compile/mod.rs 75.26% <88.88%> (+0.09%) ⬆️
...bejs-schema-compiler/src/compiler/CubeEvaluator.js 72.00% <0.00%> (ø)
...bejs-schema-compiler/src/compiler/CubeValidator.js 97.52% <0.00%> (ø)
...ejs-schema-compiler/src/adapter/PreAggregations.js 59.38% <0.00%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e3e010...d17d871. Read the comment docs.

@gandronchik gandronchik changed the title Cubesql to char query metabase to char query May 26, 2022
@gandronchik gandronchik changed the title metabase to char query metabase to_char query May 26, 2022
@gandronchik gandronchik requested a review from ovr May 27, 2022 14:31
@ovr ovr merged commit 48077a9 into master May 30, 2022
@ovr ovr deleted the cubesql-to_char-query branch May 30, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants