New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(questdb-driver): schema query error due to system tables #4762
Conversation
ebf8a8d
to
054df37
Compare
Codecov Report
@@ Coverage Diff @@
## master #4762 +/- ##
===========================================
- Coverage 72.46% 59.15% -13.32%
===========================================
Files 254 136 -118
Lines 27537 11186 -16351
Branches 2774 2781 +7
===========================================
- Hits 19955 6617 -13338
+ Misses 7076 4064 -3012
+ Partials 506 505 -1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
054df37
to
1d512be
Compare
1d512be
to
14a0d91
Compare
14a0d91
to
53cc8d5
Compare
@cristipp can you help with the review? |
test('schema', async () => { | ||
const schema = await driver.tablesSchema(); | ||
|
||
expect(schema['']).toEqual({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are the tables query_test
, telemetry
and telemetry_config
created?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
query_test
comes from the test('query', ...)
test. telemetry
and telemetry_config
are built-in tables created for the purposes of telemetry events: https://questdb.io/docs/reference/configuration/#telemetry
@@ -3,7 +3,7 @@ | |||
exports[`questdb query measure: query 1`] = ` | |||
Array [ | |||
Object { | |||
"Orders.totalAmount": "114", | |||
"Orders.totalAmount": "1700", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somewhat nervous, this test snapshot changed without an obvious corresponding change in the test spec. Is this intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change has to do with QuestDB version upgrade in integration tests. There was a bug in the query engine around aggregated over UNION ALL which was fixed recently. If you check packages/cubejs-testing/birdbox-fixtures/materialize/schema/Orders.js
, you'll notice that 1700 is the correct value.
Pushed a minor typo fix in 320bdfd |
@cristipp could you check the updates? Would be nice to get this PR merged, so that the fix is included into the next Cube release. |
Thanks for the contribution! |
Check List
Issue Reference this PR resolves
#4761