Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client-vue): Fix boolean operator in filter without using builder… #4782

Conversation

AyHaski
Copy link
Contributor

@AyHaski AyHaski commented Jun 21, 2022

…Props

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

#4781

@AyHaski AyHaski requested a review from a team as a code owner June 21, 2022 13:49
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Jun 21, 2022
@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #4782 (c2de62d) into master (0fa2995) will decrease coverage by 22.22%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #4782       +/-   ##
===========================================
- Coverage   81.37%   59.14%   -22.23%     
===========================================
  Files         119      136       +17     
  Lines       16588    11187     -5401     
  Branches        0     2687     +2687     
===========================================
- Hits        13498     6617     -6881     
- Misses       3090     4269     +1179     
- Partials        0      301      +301     
Flag Coverage Δ
cube-backend 59.14% <ø> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/cubesql/cubesql/src/sql/session_manager.rs
...cubesql/cubesql/src/compile/rewrite/rules/split.rs
...ompile/engine/information_schema/postgres/pg_am.rs
rust/cubesql/cubesql/src/transport/ext.rs
...e/information_schema/postgres/table_constraints.rs
...besql/cubesql/src/compile/rewrite/rules/members.rs
...le/engine/information_schema/postgres/pg_tables.rs
rust/cubesql/cubesql/src/sql/server_manager.rs
...ne/information_schema/postgres/key_column_usage.rs
rust/cubesql/cubesql/src/sql/dataframe.rs
... and 245 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fa2995...c2de62d. Read the comment docs.

@vasilev-alex vasilev-alex merged commit 904171e into cube-js:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants