Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): Metabase - filters with relative dates support #4851

Merged
merged 7 commits into from
Jul 12, 2022

Conversation

gandronchik
Copy link
Contributor

No description provided.

@gandronchik gandronchik requested a review from a team as a code owner July 6, 2022 11:53
@gandronchik gandronchik force-pushed the cubesql-metabase-datetrunc-now-queries branch from 920853c to c2f1f77 Compare July 7, 2022 19:19
@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #4851 (c8e302a) into master (ad3fea8) will increase coverage by 13.11%.
The diff coverage is 92.30%.

@@             Coverage Diff             @@
##           master    #4851       +/-   ##
===========================================
+ Coverage   59.88%   73.00%   +13.11%     
===========================================
  Files         138      262      +124     
  Lines       11417    29204    +17787     
  Branches     2862     2862               
===========================================
+ Hits         6837    21320    +14483     
- Misses       4078     7382     +3304     
  Partials      502      502               
Flag Coverage Δ
cube-backend 59.84% <ø> (-0.05%) ⬇️
cubesql 81.45% <92.30%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...besql/cubesql/src/compile/rewrite/rules/filters.rs 85.81% <63.63%> (ø)
rust/cubesql/cubesql/src/compile/engine/udf.rs 86.63% <90.90%> (ø)
...st/cubesql/cubesql/src/compile/rewrite/analysis.rs 93.52% <96.55%> (ø)
rust/cubesql/cubesql/src/compile/mod.rs 78.54% <100.00%> (ø)
...st/cubesql/cubesql/src/compile/rewrite/language.rs 69.18% <100.00%> (ø)
...st/cubesql/cubesql/src/compile/rewrite/rewriter.rs 28.38% <100.00%> (ø)
...cubesql/cubesql/src/compile/rewrite/rules/dates.rs 100.00% <100.00%> (ø)
...es/cubejs-schema-compiler/src/adapter/BaseQuery.js 64.82% <0.00%> (-0.41%) ⬇️
.../compile/engine/information_schema/postgres/ext.rs 100.00% <0.00%> (ø)
rust/cubesql/cubesql/src/compile/engine/df/scan.rs 75.37% <0.00%> (ø)
... and 122 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad3fea8...c8e302a. Read the comment docs.

@gandronchik gandronchik force-pushed the cubesql-metabase-datetrunc-now-queries branch from 19494a9 to c8e302a Compare July 12, 2022 08:32
@gandronchik gandronchik merged commit 423be2f into master Jul 12, 2022
@gandronchik gandronchik deleted the cubesql-metabase-datetrunc-now-queries branch July 12, 2022 10:23
@rpaik rpaik added the Roadmap: 2022 Q2 Cube roadmap for Q2 of 2022 label Jul 12, 2022
@rpaik rpaik added this to Done in Roadmap 2022 Q2 Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Roadmap: 2022 Q2 Cube roadmap for Q2 of 2022
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants