Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): Support DAY/DOW aggregations (Metabase) #4887

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

ovr
Copy link
Member

@ovr ovr commented Jul 11, 2022

Hello!

Thanks

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #4887 (96a7864) into master (8fadebd) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4887      +/-   ##
==========================================
+ Coverage   72.88%   72.94%   +0.06%     
==========================================
  Files         262      262              
  Lines       29044    29110      +66     
  Branches     2858     2858              
==========================================
+ Hits        21168    21234      +66     
  Misses       7374     7374              
  Partials      502      502              
Flag Coverage Δ
cube-backend 59.86% <ø> (ø)
cubesql 81.37% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/cubesql/cubesql/src/compile/mod.rs 78.33% <100.00%> (+0.19%) ⬆️
...besql/cubesql/src/compile/rewrite/rules/members.rs 98.02% <100.00%> (+0.02%) ⬆️
...cubesql/cubesql/src/compile/rewrite/rules/split.rs 97.10% <100.00%> (+0.11%) ⬆️
...st/cubesql/cubesql/src/compile/rewrite/analysis.rs 92.15% <0.00%> (-0.40%) ⬇️
rust/cubesql/cubesql/src/sql/statement.rs 74.82% <0.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fadebd...96a7864. Read the comment docs.

@ovr ovr force-pushed the cubesql-metabase-dow-doy branch 2 times, most recently from 0f13a27 to f7e3622 Compare July 11, 2022 16:45
@ovr ovr force-pushed the cubesql-metabase-dow-doy branch from f7e3622 to 96a7864 Compare July 11, 2022 17:56
@ovr ovr marked this pull request as ready for review July 11, 2022 18:03
@ovr ovr requested review from a team as code owners July 11, 2022 18:03
@ovr ovr merged commit 2565705 into master Jul 11, 2022
@ovr ovr deleted the cubesql-metabase-dow-doy branch July 11, 2022 18:29
@rpaik rpaik added the Roadmap: 2022 Q2 Cube roadmap for Q2 of 2022 label Jul 12, 2022
@rpaik rpaik added this to Done in Roadmap 2022 Q2 Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Roadmap: 2022 Q2 Cube roadmap for Q2 of 2022
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants