Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): Support minus, multiply, division for binary expr in projection #4899

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

ovr
Copy link
Member

@ovr ovr commented Jul 12, 2022

Hello!

In the previous PR I've added support for BinaryExpr with + operator:

2565705#diff-7dc005dcca36d622711495451619971bf9af578e1f4e84871047603a52027f70R571

This PR allows to do +, -, / and * excluding * 0.

Thanks

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #4899 (1155939) into master (817fecf) will decrease coverage by 8.56%.
The diff coverage is 85.71%.

❗ Current head 1155939 differs from pull request most recent head 70bafcb. Consider uploading reports for the commit 70bafcb to get more accurate results

@@            Coverage Diff             @@
##           master    #4899      +/-   ##
==========================================
- Coverage   81.76%   73.19%   -8.57%     
==========================================
  Files         124      262     +138     
  Lines       17988    29359   +11371     
  Branches        0     2880    +2880     
==========================================
+ Hits        14708    21490    +6782     
- Misses       3280     7367    +4087     
- Partials        0      502     +502     
Flag Coverage Δ
cube-backend 59.83% <ø> (?)
cubesql 81.69% <85.71%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...cubesql/cubesql/src/compile/rewrite/rules/split.rs 95.56% <79.54%> (-1.54%) ⬇️
rust/cubesql/cubesql/src/compile/mod.rs 78.90% <100.00%> (-0.12%) ⬇️
rust/cubesql/cubesql/src/sql/types.rs 50.00% <0.00%> (-0.99%) ⬇️
rust/cubesql/cubesql/src/sql/postgres/shim.rs 64.57% <0.00%> (-0.39%) ⬇️
rust/cubesql/cubesql/src/compile/engine/udf.rs 86.73% <0.00%> (-0.27%) ⬇️
rust/cubesql/cubesql/src/sql/statement.rs 74.64% <0.00%> (-0.18%) ⬇️
...ubejs-api-gateway/src/helpers/prepareAnnotation.ts 93.93% <0.00%> (ø)
packages/cubejs-backend-shared/src/promises.ts 96.27% <0.00%> (ø)
...uery-orchestrator/src/orchestrator/TimeoutError.ts 100.00% <0.00%> (ø)
... and 136 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4846db0...70bafcb. Read the comment docs.

@ovr ovr force-pushed the cubesql-any-binary-op branch 2 times, most recently from 8bc3f5f to 88edcb6 Compare July 12, 2022 18:11
@ovr ovr marked this pull request as ready for review July 14, 2022 15:55
@ovr ovr requested a review from a team as a code owner July 14, 2022 15:55
@ovr ovr changed the title feat(cubesql): Support any BinaryExpr for projection in rewritting feat(cubesql): Support minus, multiply, division for binary expr in projection Jul 15, 2022
@ovr ovr merged commit 1fc653b into master Jul 15, 2022
@ovr ovr deleted the cubesql-any-binary-op branch July 15, 2022 11:42
nayakravi pushed a commit to trueanthem/cube.js that referenced this pull request Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant