Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): Metabase string contains / not contains filters #4922

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

gandronchik
Copy link
Contributor

  • WHERE (lower(column) like '%value%')
  • WHERE (NOT (lower(column) like '%value%') OR column IS NULL)

@gandronchik gandronchik requested a review from a team as a code owner July 15, 2022 08:53
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #4922 (8fcdf1a) into master (8fcdf1a) will not change coverage.
The diff coverage is n/a.

❗ Current head 8fcdf1a differs from pull request most recent head d3279eb. Consider uploading reports for the commit d3279eb to get more accurate results

@@           Coverage Diff           @@
##           master    #4922   +/-   ##
=======================================
  Coverage   73.38%   73.38%           
=======================================
  Files         263      263           
  Lines       29615    29615           
  Branches     2880     2880           
=======================================
  Hits        21734    21734           
  Misses       7379     7379           
  Partials      502      502           
Flag Coverage Δ
cube-backend 59.88% <0.00%> (ø)
cubesql 81.86% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fcdf1a...d3279eb. Read the comment docs.

@gandronchik gandronchik merged commit e5abc09 into master Jul 18, 2022
@gandronchik gandronchik deleted the cubesql-contains-query branch July 18, 2022 08:06
nayakravi pushed a commit to trueanthem/cube.js that referenced this pull request Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants