Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cubesql): array_upper && array_lower UDFs return type fix #5136

Merged
merged 2 commits into from Aug 22, 2022

Conversation

gandronchik
Copy link
Contributor

No description provided.

@gandronchik gandronchik requested a review from a team as a code owner August 22, 2022 13:08
@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #5136 (9d5fbe6) into master (b710c95) will decrease coverage by 0.00%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master    #5136      +/-   ##
==========================================
- Coverage   74.45%   74.45%   -0.01%     
==========================================
  Files         268      268              
  Lines       31142    31144       +2     
  Branches     2912     2912              
==========================================
+ Hits        23187    23188       +1     
- Misses       7453     7454       +1     
  Partials      502      502              
Flag Coverage Δ
cube-backend 60.09% <ø> (ø)
cubesql 82.93% <85.71%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/cubesql/cubesql/src/compile/mod.rs 80.97% <80.00%> (-0.03%) ⬇️
rust/cubesql/cubesql/src/compile/engine/udf.rs 86.84% <100.00%> (+0.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gandronchik gandronchik merged commit 9451a86 into master Aug 22, 2022
@gandronchik gandronchik deleted the cubesql-array-upper-lower-fix branch August 22, 2022 14:53
nayakravi pushed a commit to trueanthem/cube.js that referenced this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants