Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): Push down limit through projection #5206

Merged
merged 3 commits into from
Sep 1, 2022

Conversation

ovr
Copy link
Member

@ovr ovr commented Aug 31, 2022

No description provided.

@ovr ovr requested a review from a team as a code owner August 31, 2022 16:51
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #5206 (38fdcc8) into master (7a6f8f9) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5206      +/-   ##
==========================================
+ Coverage   74.68%   74.72%   +0.03%     
==========================================
  Files         270      270              
  Lines       31544    31584      +40     
  Branches     2918     2918              
==========================================
+ Hits        23559    23600      +41     
+ Misses       7481     7480       -1     
  Partials      504      504              
Flag Coverage Δ
cube-backend 60.08% <ø> (ø)
cubesql 83.21% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/cubesql/cubesql/src/compile/mod.rs 81.45% <100.00%> (+0.10%) ⬆️
...besql/cubesql/src/compile/rewrite/rules/filters.rs 90.86% <100.00%> (+0.11%) ⬆️
rust/cubesql/cubesql/src/sql/statement.rs 74.56% <0.00%> (+0.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ovr ovr force-pushed the cubesql-limit-push-down-projection branch from 7f2843a to 0bc267a Compare August 31, 2022 18:08
@ovr ovr merged commit 3c6ff7d into master Sep 1, 2022
@ovr ovr deleted the cubesql-limit-push-down-projection branch September 1, 2022 11:45
nayakravi pushed a commit to trueanthem/cube.js that referenced this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants