Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cubesql): Allow yyyy, dd, mi, ss in to_timestamp #5218

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

MazterQyou
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

This PR adds support for yyyy, dd, mi, ss lowercase placeholders in format string of to_timestamp function. These are used by QuickSight. It also adds a related test.

@MazterQyou MazterQyou requested a review from a team as a code owner September 1, 2022 11:17
@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #5218 (e7c8099) into master (7a6f8f9) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5218      +/-   ##
==========================================
+ Coverage   74.68%   74.71%   +0.02%     
==========================================
  Files         270      270              
  Lines       31544    31567      +23     
  Branches     2918     2918              
==========================================
+ Hits        23559    23585      +26     
+ Misses       7481     7478       -3     
  Partials      504      504              
Flag Coverage Δ
cube-backend 60.08% <ø> (ø)
cubesql 83.20% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/cubesql/cubesql/src/compile/engine/udf.rs 86.84% <ø> (ø)
rust/cubesql/cubesql/src/compile/mod.rs 81.44% <100.00%> (+0.10%) ⬆️
rust/cubesql/cubesql/src/sql/statement.rs 74.74% <0.00%> (+0.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@ovr ovr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ovr ovr merged commit 044c3e1 into master Sep 1, 2022
@ovr ovr deleted the cubesql/postgres-to-iso-date-fix branch September 1, 2022 13:57
nayakravi pushed a commit to trueanthem/cube.js that referenced this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants