Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cubesql): udf format_type prepared statement fix #5260

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

gandronchik
Copy link
Contributor

  • udf format_type has not worked via prepared statements until this PR

@gandronchik gandronchik requested a review from a team as a code owner September 8, 2022 10:10
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Base: 75.90% // Head: 75.90% // No change to project coverage 👍

Coverage data is based on head (a25c8bf) compared to base (a25c8bf).
Patch has no changes to coverable lines.

❗ Current head a25c8bf differs from pull request most recent head 49ed89c. Consider uploading reports for the commit 49ed89c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5260   +/-   ##
=======================================
  Coverage   75.90%   75.90%           
=======================================
  Files         275      275           
  Lines       33365    33365           
  Branches     2859     2859           
=======================================
  Hits        25326    25326           
  Misses       7751     7751           
  Partials      288      288           
Flag Coverage Δ
cube-backend 60.15% <0.00%> (ø)
cubesql 84.40% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gandronchik gandronchik merged commit 307ed1b into master Sep 30, 2022
@gandronchik gandronchik deleted the cubesql-format_type-ps-fix branch September 30, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants