feat(testing): databricks test suite #5311
Conversation
github-actions
bot
added
the
pr:community
Codecov ReportBase: 60.15% // Head: 60.15% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #5311 +/- ##
========================================
Coverage 60.15% 60.15%
========================================
Files 140 140
Lines 11684 11684
Branches 2945 2853 -92
========================================
Hits 7028 7028
- Misses 4150 4368 +218
+ Partials 506 288 -218
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| @@ -518,6 +531,7 @@ export async function startBirdBoxFromCli( | |||
| CUBEJS_API_SECRET: 'mysupersecret', | |||
| CUBEJS_WEB_SOCKETS: 'true', | |||
| CUBEJS_PLAYGROUND_AUTH_SECRET: 'mysupersecret', | |||
| CUBEJS_TELEMETRY: 'false', | |||
There was a problem hiding this comment.
📓 I guess it's useless to use telemetry in tests
| @@ -509,6 +520,8 @@ export async function startBirdBoxFromCli( | |||
| ); | |||
| } | |||
|
|
|||
| fs.writeFileSync(path.join(testDir, 'package.json'), '{}', { encoding: 'utf-8' }); | |||
There was a problem hiding this comment.
📓 required to avoid such error
RequestError: Error: ENOENT: no such file or directory, open ‘package.json’
There was a problem hiding this comment.
I'm not sure this is required.
There was a problem hiding this comment.
Tests don't pass without it
| @@ -37,6 +41,10 @@ export const DATE_CAST = { | |||
| DATE_PREFIX: 'to_date(', | |||
| DATE_SUFFIX: ', \'YYYY-MM-DD\')', | |||
| }, | |||
| 'databricks-jdbc': { | |||
| DATE_PREFIX: 'to_date(', | |||
| DATE_SUFFIX: ', \'y-M-d\')', | |||
| @@ -0,0 +1,9 @@ | |||
| // Cube.js configuration options: https://cube.dev/docs/config | |||
| module.exports = { | |||
| queryRewrite: (query) => { | |||
There was a problem hiding this comment.
Why do you need this? We do not use the Orders cube in the test suit.
There was a problem hiding this comment.
Just an accidental copypaste from Postgres
| @@ -509,6 +520,8 @@ export async function startBirdBoxFromCli( | |||
| ); | |||
| } | |||
|
|
|||
| fs.writeFileSync(path.join(testDir, 'package.json'), '{}', { encoding: 'utf-8' }); | |||
There was a problem hiding this comment.
I'm not sure this is required.
buntarb
changed the title
Check List
Issue Reference this PR resolves
[For example #12]
Description of Changes Made (if issue reference is not provided)
[Description goes here]