Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multiple data source #5326

Merged
merged 11 commits into from
Sep 30, 2022
Merged

feat: multiple data source #5326

merged 11 commits into from
Sep 30, 2022

Conversation

buntarb
Copy link
Contributor

@buntarb buntarb commented Sep 20, 2022

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@buntarb buntarb force-pushed the features/multiple_ds branch 2 times, most recently from 43592a9 to be18e32 Compare September 26, 2022 13:04
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Base: 75.85% // Head: 60.79% // Decreases project coverage by -15.05% ⚠️

Coverage data is based on head (c95876b) compared to base (2269b2b).
Patch coverage: 86.13% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5326       +/-   ##
===========================================
- Coverage   75.85%   60.79%   -15.06%     
===========================================
  Files         275      140      -135     
  Lines       33305    11836    -21469     
  Branches     2859     2900       +41     
===========================================
- Hits        25263     7196    -18067     
+ Misses       7754     4352     -3402     
  Partials      288      288               
Flag Coverage Δ
cube-backend 60.79% <86.13%> (+0.68%) ⬆️
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/cubejs-server-core/src/core/DevServer.ts 8.23% <4.54%> (-0.07%) ⬇️
packages/cubejs-base-driver/src/BaseDriver.ts 27.16% <16.66%> (ø)
packages/cubejs-backend-shared/src/env.ts 67.80% <98.79%> (+37.15%) ⬆️
packages/cubejs-backend-shared/src/index.ts 100.00% <100.00%> (ø)
...ackages/cubejs-server-core/src/core/OptsHandler.ts 87.65% <100.00%> (+0.05%) ⬆️
packages/cubejs-server-core/src/core/server.ts 66.76% <100.00%> (+0.09%) ⬆️
rust/cubesql/cubesql/src/sql/session_manager.rs
rust/cubesql/cubesql/src/sql/postgres/shim.rs
rust/cubesql/cubesql/e2e/tests/postgres.rs
...esql/cubeclient/src/models/v1_cube_meta_segment.rs
... and 132 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@buntarb buntarb marked this pull request as ready for review September 30, 2022 10:24
@buntarb buntarb requested review from a team as code owners September 30, 2022 10:24
@buntarb buntarb merged commit 334af8c into master Sep 30, 2022
@buntarb buntarb deleted the features/multiple_ds branch September 30, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant