Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cubesql): WHERE Lower / Upper in list with multiply items #5376

Merged
merged 1 commit into from Sep 29, 2022

Conversation

gandronchik
Copy link
Contributor

select * from table where lower(column) in ('a', 'b');

@gandronchik gandronchik requested a review from a team as a code owner September 28, 2022 13:14
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Base: 75.78% // Head: 75.84% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (103c1f8) compared to base (6d6f359).
Patch coverage: 99.04% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5376      +/-   ##
==========================================
+ Coverage   75.78%   75.84%   +0.06%     
==========================================
  Files         275      275              
  Lines       33213    33305      +92     
  Branches     2859     2859              
==========================================
+ Hits        25171    25261      +90     
- Misses       7754     7756       +2     
  Partials      288      288              
Flag Coverage Δ
cube-backend 60.11% <ø> (ø)
cubesql 84.35% <99.04%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...besql/cubesql/src/compile/rewrite/rules/filters.rs 93.06% <96.15%> (-0.02%) ⬇️
rust/cubesql/cubesql/src/compile/mod.rs 90.86% <100.00%> (+0.14%) ⬆️
rust/cubesql/cubesql/src/sql/postgres/shim.rs 68.30% <0.00%> (-0.16%) ⬇️
rust/cubesql/cubesql/src/sql/statement.rs 75.45% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gandronchik gandronchik merged commit 2269b2b into master Sep 29, 2022
@gandronchik gandronchik deleted the cubesql-lower-in-list-fix branch September 29, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant