Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cubesql): Allow derived tables to have a dot in column name #5391

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

MazterQyou
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR bumps datafusion in order to fix an issue with derived tables where you could not have a dot in a column alias of a derived table. It also adds a related test with a query used by PowerBI.

@MazterQyou MazterQyou requested a review from a team as a code owner September 30, 2022 08:00
@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Base: 75.88% // Head: 75.92% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (f6d4a5f) compared to base (e99344f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5391      +/-   ##
==========================================
+ Coverage   75.88%   75.92%   +0.03%     
==========================================
  Files         275      275              
  Lines       33349    33381      +32     
  Branches     2859     2859              
==========================================
+ Hits        25308    25343      +35     
+ Misses       7753     7750       -3     
  Partials      288      288              
Flag Coverage Δ
cube-backend 60.15% <ø> (ø)
cubesql 84.41% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/cubesql/cubesql/src/compile/mod.rs 90.97% <100.00%> (+0.05%) ⬆️
rust/cubesql/cubesql/src/compile/rewrite/cost.rs 96.72% <0.00%> (+0.05%) ⬆️
rust/cubesql/cubesql/src/sql/statement.rs 75.85% <0.00%> (+0.16%) ⬆️
...ne/information_schema/postgres/testing_blocking.rs 54.54% <0.00%> (+18.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gandronchik gandronchik merged commit f83009c into master Sep 30, 2022
@gandronchik gandronchik deleted the cubesql/derived-dot-unqualified branch September 30, 2022 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants