Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(postgres-driver): release method should not throw #5395

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

buntarb
Copy link
Contributor

@buntarb buntarb commented Sep 30, 2022

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@buntarb buntarb requested a review from a team as a code owner September 30, 2022 15:30
@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Base: 76.17% // Head: 60.84% // Decreases project coverage by -15.33% ⚠️

Coverage data is based on head (0934512) compared to base (da4304f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5395       +/-   ##
===========================================
- Coverage   76.17%   60.84%   -15.34%     
===========================================
  Files         275      140      -135     
  Lines       33702    11837    -21865     
  Branches     2900     2901        +1     
===========================================
- Hits        25674     7202    -18472     
+ Misses       7740     4347     -3393     
  Partials      288      288               
Flag Coverage Δ
cube-backend 60.84% <ø> (+<0.01%) ⬆️
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/cubesql/pg-srv/src/lib.rs
rust/cubesql/cubesql/src/telemetry/mod.rs
rust/cubesql/cubesql/src/sql/statement.rs
...models/v1_load_request_query_filter_logical_and.rs
...cubesql/cubesql/src/compile/rewrite/rules/order.rs
...mpile/engine/information_schema/mysql/variables.rs
rust/cubesql/cubesql/src/compile/engine/context.rs
rust/cubesql/pg-srv/src/protocol.rs
...t/cubesql/cubesql/src/compile/rewrite/rules/mod.rs
...pile/engine/information_schema/postgres/pg_enum.rs
... and 126 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@buntarb buntarb merged commit 9423f46 into master Sep 30, 2022
@buntarb buntarb deleted the bugfix/postgres_release_call_error branch September 30, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant