Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query-orchestrator): Introduce CubeStoreCacheDriver #5511

Merged
merged 10 commits into from Dec 31, 2022

Conversation

ovr
Copy link
Member

@ovr ovr commented Oct 21, 2022

Hello!

This PR introduces initial support for caching in Cube Store.

image

Thanks

@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Base: 41.04% // Head: 40.79% // Decreases project coverage by -0.25% ⚠️

Coverage data is based on head (a6f0e83) compared to base (5dd78b9).
Patch coverage: 55.76% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5511      +/-   ##
==========================================
- Coverage   41.04%   40.79%   -0.26%     
==========================================
  Files         149      150       +1     
  Lines       19558    19721     +163     
  Branches     5090     5138      +48     
==========================================
+ Hits         8028     8045      +17     
- Misses      10710    10851     +141     
- Partials      820      825       +5     
Flag Coverage Δ
cube-backend 40.79% <55.76%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-orchestrator/src/orchestrator/LocalCacheDriver.ts 78.78% <ø> (ø)
...-orchestrator/src/orchestrator/RedisCacheDriver.ts 3.50% <0.00%> (-0.27%) ⬇️
...-query-orchestrator/src/orchestrator/QueryQueue.js 67.60% <33.33%> (-1.49%) ⬇️
...-query-orchestrator/src/orchestrator/QueryCache.ts 73.78% <54.54%> (-2.02%) ⬇️
...orchestrator/src/orchestrator/QueryOrchestrator.ts 58.50% <66.66%> (+0.28%) ⬆️
packages/cubejs-base-driver/src/index.ts 100.00% <100.00%> (ø)
...y-orchestrator/src/orchestrator/BaseQueueDriver.ts 100.00% <100.00%> (ø)
...y-orchestrator/src/orchestrator/PreAggregations.ts 78.28% <100.00%> (ø)
...bejs-schema-compiler/src/adapter/CubeStoreQuery.ts 3.78% <100.00%> (ø)
...cubejs-schema-compiler/src/adapter/QueryBuilder.js 71.42% <100.00%> (+1.05%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ovr ovr force-pushed the query-orchestrator-cubestore-driver branch 4 times, most recently from 01fdc3a to 9367cbb Compare December 27, 2022 21:50
@ovr ovr force-pushed the query-orchestrator-cubestore-driver branch from 9367cbb to 317d1e2 Compare December 30, 2022 13:20
@ovr ovr marked this pull request as ready for review December 30, 2022 16:25
@ovr ovr requested review from a team as code owners December 30, 2022 16:25
@ovr ovr merged commit fb39776 into master Dec 31, 2022
@ovr ovr deleted the query-orchestrator-cubestore-driver branch December 31, 2022 10:40
@rpaik rpaik added Epic Major changes and features from the core team. backend:cube-store Issues relating to Cube Store Roadmap: 2022 Q4 Cube roadmap for Q4 of 2022 labels Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:cube-store Issues relating to Cube Store Epic Major changes and features from the core team. Roadmap: 2022 Q4 Cube roadmap for Q4 of 2022
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants