Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@cubejs-backend/mssql-driver): Make MSSQL readOnly by default #5584

Merged
merged 3 commits into from Nov 8, 2022

Conversation

paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Nov 8, 2022

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

#5563

@paveltiunov paveltiunov requested review from a team as code owners November 8, 2022 02:42
@paveltiunov paveltiunov changed the title feat(@cubejs-backend/mssql-driver): Make MSSQL readOnly by default feat(@cubejs-backend/mssql-driver): Make MSSQL readOnly by default Nov 8, 2022
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 40.60% // Head: 40.60% // No change to project coverage 👍

Coverage data is based on head (9003984) compared to base (ca8fd4e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5584   +/-   ##
=======================================
  Coverage   40.60%   40.60%           
=======================================
  Files         144      144           
  Lines       19354    19354           
  Branches     4903     4903           
=======================================
  Hits         7858     7858           
  Misses      11191    11191           
  Partials      305      305           
Flag Coverage Δ
cube-backend 40.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@paveltiunov paveltiunov merged commit ddf0369 into master Nov 8, 2022
@paveltiunov paveltiunov deleted the mssql-readonly-by-default branch November 8, 2022 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant