Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): Join Cubes #5585

Merged
merged 7 commits into from Nov 11, 2022
Merged

Conversation

gandronchik
Copy link
Contributor

No description provided.

@gandronchik gandronchik requested a review from a team as a code owner November 8, 2022 15:41
@gandronchik gandronchik marked this pull request as draft November 8, 2022 15:41
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 40.60% // Head: 60.49% // Increases project coverage by +19.89% 🎉

Coverage data is based on head (2002f2d) compared to base (ddf0369).
Patch coverage: 97.30% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5585       +/-   ##
===========================================
+ Coverage   40.60%   60.49%   +19.89%     
===========================================
  Files         144      281      +137     
  Lines       19354    37192    +17838     
  Branches     4903     4903               
===========================================
+ Hits         7858    22500    +14642     
- Misses      11191    14387     +3196     
  Partials      305      305               
Flag Coverage Δ
cube-backend 40.57% <ø> (-0.03%) ⬇️
cubesql 82.11% <97.30%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/cubesql/cubeclient/src/models/v1_cube_meta.rs 0.00% <ø> (ø)
...ql/cubeclient/src/models/v1_cube_meta_dimension.rs 0.00% <ø> (ø)
...cubesql/cubeclient/src/models/v1_cube_meta_join.rs 0.00% <0.00%> (ø)
...esql/cubeclient/src/models/v1_cube_meta_measure.rs 0.00% <ø> (ø)
...esql/cubeclient/src/models/v1_cube_meta_segment.rs 0.00% <ø> (ø)
rust/cubesql/cubeclient/src/models/v1_error.rs 0.00% <ø> (ø)
...t/cubesql/cubeclient/src/models/v1_load_request.rs 0.00% <ø> (ø)
...sql/cubeclient/src/models/v1_load_request_query.rs 100.00% <ø> (ø)
...nt/src/models/v1_load_request_query_filter_base.rs 0.00% <ø> (ø)
...nt/src/models/v1_load_request_query_filter_item.rs 0.00% <ø> (ø)
... and 158 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gandronchik gandronchik marked this pull request as ready for review November 9, 2022 14:55
@gandronchik gandronchik requested a review from a team as a code owner November 11, 2022 11:07
@gandronchik gandronchik requested a review from ovr November 11, 2022 15:05
@gandronchik gandronchik merged commit c687e42 into master Nov 11, 2022
@gandronchik gandronchik deleted the cubesql/join-to-cross-join-wip branch November 11, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants