Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: catalog support for the Databricks driver #5666

Merged
merged 3 commits into from Nov 29, 2022

Conversation

buntarb
Copy link
Contributor

@buntarb buntarb commented Nov 22, 2022

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@buntarb buntarb requested review from a team as code owners November 22, 2022 09:02
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 82.14% // Head: 40.92% // Decreases project coverage by -41.21% ⚠️

Coverage data is based on head (87ee4a3) compared to base (eabfd46).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5666       +/-   ##
===========================================
- Coverage   82.14%   40.92%   -41.22%     
===========================================
  Files         137      149       +12     
  Lines       17928    19467     +1539     
  Branches        0     4938     +4938     
===========================================
- Hits        14727     7967     -6760     
- Misses       3201    11195     +7994     
- Partials        0      305      +305     
Flag Coverage Δ
cube-backend 40.92% <66.66%> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/cubejs-base-driver/src/BaseDriver.ts 26.82% <0.00%> (ø)
...ackages/cubejs-base-driver/src/driver.interface.ts 50.00% <ø> (ø)
packages/cubejs-backend-shared/src/env.ts 68.00% <100.00%> (ø)
...y-orchestrator/src/orchestrator/PreAggregations.ts 78.42% <100.00%> (ø)
...st/cubesql/cubesql/src/compile/engine/df/coerce.rs
rust/cubesql/cubesql/src/compile/builder.rs
...e/engine/information_schema/redshift/svv_tables.rs
rust/cubesql/cubesql/src/compile/rewrite/mod.rs
...besql/cubesql/src/compile/rewrite/rules/filters.rs
...cubesql/cubesql/src/compile/rewrite/rules/split.rs
... and 280 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@buntarb buntarb force-pushed the features/databricks_catalog_support branch from d63d7f6 to 87ee4a3 Compare November 28, 2022 22:08
@buntarb buntarb merged commit de5ba9a into master Nov 29, 2022
@buntarb buntarb deleted the features/databricks_catalog_support branch November 29, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant