Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: More explanatory No pre-aggregation partitions were built yet #5702

Merged
merged 2 commits into from Dec 2, 2022

Conversation

paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Dec 1, 2022

…message

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@paveltiunov paveltiunov requested a review from a team as a code owner December 1, 2022 23:35
@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Base: 40.92% // Head: 40.93% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (87f499d) compared to base (81b2247).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5702      +/-   ##
==========================================
+ Coverage   40.92%   40.93%   +0.01%     
==========================================
  Files         149      149              
  Lines       19467    19471       +4     
  Branches     4938     4939       +1     
==========================================
+ Hits         7967     7971       +4     
  Misses      11195    11195              
  Partials      305      305              
Flag Coverage Δ
cube-backend 40.93% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...y-orchestrator/src/orchestrator/PreAggregations.ts 78.52% <100.00%> (+0.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@paveltiunov paveltiunov merged commit ec39baa into master Dec 2, 2022
@paveltiunov paveltiunov deleted the no-pre-aggs-were-built-yet-message branch December 2, 2022 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant