Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-gateway, server-core): Added dataSources method #5789

Merged
merged 3 commits into from
Jan 23, 2023
Merged

Conversation

wolfeeeg
Copy link
Contributor

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Dec 12, 2022
@wolfeeeg wolfeeeg force-pushed the CC-1660-2 branch 2 times, most recently from f1bfdcb to 5f77273 Compare December 12, 2022 12:04
@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Base: 41.29% // Head: 41.36% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (cdb5cc1) compared to base (89f1b92).
Patch coverage: 93.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5789      +/-   ##
==========================================
+ Coverage   41.29%   41.36%   +0.07%     
==========================================
  Files         151      151              
  Lines       19975    20005      +30     
  Branches     5189     5194       +5     
==========================================
+ Hits         8248     8276      +28     
- Misses      10896    10898       +2     
  Partials      831      831              
Flag Coverage Δ
cube-backend 41.36% <93.33%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/cubejs-api-gateway/src/gateway.ts 59.77% <90.00%> (+0.38%) ⬆️
...ackages/cubejs-server-core/src/core/CompilerApi.js 84.87% <95.00%> (+2.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wolfeeeg wolfeeeg force-pushed the CC-1660-2 branch 2 times, most recently from ff471a6 to 08ef21f Compare December 12, 2022 14:47
@wolfeeeg wolfeeeg force-pushed the CC-1660-2 branch 2 times, most recently from d5b0a3f to ca8547a Compare December 12, 2022 15:48
@wolfeeeg wolfeeeg marked this pull request as ready for review December 12, 2022 16:24
@wolfeeeg wolfeeeg requested a review from a team as a code owner December 12, 2022 16:24
Copy link
Contributor

@buntarb buntarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

@wolfeeeg wolfeeeg merged commit 128d017 into master Jan 23, 2023
@wolfeeeg wolfeeeg deleted the CC-1660-2 branch January 23, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants