Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubestore): Introduce pre-aggregation table touch and allow to d… #5794

Merged
merged 1 commit into from Dec 13, 2022

Conversation

paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Dec 13, 2022

…rop tables without touch using CUBEJS_DROP_PRE_AGG_WITHOUT_TOUCH env

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

…rop tables without touch using `CUBEJS_DROP_PRE_AGG_WITHOUT_TOUCH` env
@paveltiunov paveltiunov requested review from a team as code owners December 13, 2022 03:14
@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Base: 81.69% // Head: 41.00% // Decreases project coverage by -40.69% ⚠️

Coverage data is based on head (14e3766) compared to base (7d705c8).
Patch coverage: 60.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5794       +/-   ##
===========================================
- Coverage   81.69%   41.00%   -40.70%     
===========================================
  Files         139      149       +10     
  Lines       18540    19520      +980     
  Branches        0     4960     +4960     
===========================================
- Hits        15147     8004     -7143     
- Misses       3393    11211     +7818     
- Partials        0      305      +305     
Flag Coverage Δ
cube-backend 41.00% <60.00%> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/cubejs-backend-shared/src/env.ts 67.17% <0.00%> (ø)
...y-orchestrator/src/orchestrator/PreAggregations.ts 78.07% <64.28%> (ø)
rust/cubesql/cubesql/src/transport/ctx.rs
rust/cubesql/cubesql/src/error.rs
...src/models/v1_load_request_query_time_dimension.rs
...ile/engine/information_schema/postgres/pg_roles.rs
...st/cubesql/cubesql/src/compile/rewrite/language.rs
...cubesql/cubesql/src/compile/rewrite/rules/utils.rs
...cubeclient/src/models/v1_load_result_annotation.rs
...cubesql/cubesql/src/compile/rewrite/rules/split.rs
... and 280 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@paveltiunov paveltiunov merged commit ad6c1e8 into master Dec 13, 2022
@paveltiunov paveltiunov deleted the refresh-touch branch December 13, 2022 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant